Re-define Unitful's yr (year) unit to be 365.2425 days #740
+40
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the true average number of days in the Gregorian year, every year that is exactly divisible by four is a leap year, except for years that are exactly divisible by 100, but these centurial years are leap years, if they are exactly divisible by 400. See `Dates.isleapyear`: https://github.com/JuliaLang/julia/blob/00739173/stdlib/Dates/src/types.jl#L206
The average number of days in a year should be the same in both Unitful and the Dates stdlib. We also add a reference to this function in the documentation for this unit.
|
Apologies, I made a syntax error that I didn't catch. I've rectified it. |
|
To me, 365.2425 days seems like the correct value. I don’t know why 365.25 was chosen. Maybe there is a scientific field where 365.25 days is commonly used? Anyway, I think this is a good change, but I consider it breaking, so it can only be changed in Unitful v2.0. |
|
I do not know whether this is related, but the light year seems to be defined by the Julian year, so it might make sense to check whether UnitfulAstro is affected by this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify Unitful's year unit to be 365.2425 days.
This is the true average number of days in the Gregorian year, every year that is exactly divisible by four is a leap year, except for years that are exactly divisible by 100, but these centurial years are leap years, if they are exactly divisible by 400.
See
Dates.isleapyearandDates.days(::Year).This is a suggested change in the interest of correctness, but it likely doesn't make much of a difference to most people!
See also #288.